Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPP v1.6 ReserveNow call does not follow standard #48

Closed
psauer opened this issue Nov 18, 2019 · 2 comments
Closed

OCPP v1.6 ReserveNow call does not follow standard #48

psauer opened this issue Nov 18, 2019 · 2 comments
Assignees
@tropxy
Labels
bug Something isn't working

Comments

@psauer
Copy link

psauer commented Nov 18, 2019

ocpp/ocpp/v16/call.py

Line 96 in 75dd91f

parent_id_tag: str

In the ReserveNowPayload, the parent_id_tag field is optional, but is not reflected here. It should be parent_id_tag: str = None. This lead to an error when receiving a ReserveNowPayload with the parent_id_tag not sent.
@tropxy
Copy link
Collaborator

tropxy commented Nov 18, 2019

You are indeed correct @psauer. Thanks for your report. We will address this issue asap.

@OrangeTux OrangeTux added the bug Something isn't working label Nov 18, 2019
@tropxy tropxy self-assigned this Nov 18, 2019
@tropxy tropxy mentioned this issue Nov 18, 2019
Merged
@OrangeTux
Copy link
Contributor

This issue has been fixed in v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tropxy tropxy

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OrangeTux @psauer @tropxy