Improve Exception handling and CallError responses #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
OrangeTux
approved these changes
May 11, 2022
|
❤️ |
ajmirsky
pushed a commit
to ajmirsky/ocpp
that referenced
this pull request
Nov 26, 2024
* Added missing NotSupported to the exception list. * Changed usage of NotImplemented to NotSupported when a handler doesn't exist. *Use the default description and moved additional information to details * Reduce the usage of ValidationError as it is not a valid OCPP error type, doesn't generate a CallError, and crashes the code when handling messages. I've tried to replace them with relevant OCPP error types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to improve the exception handling in validating messages and to make the CallError messages closer to the OCPP spec. Quick overview:
NotSupportedto the exception list.NotImplementedtoNotSupportedwhen a handler doesn't exist.detailsValidationErroras it is not a valid OCPP error type, doesn't generate a CallError, and crashes the code when handling messages. I've tried to replace them with relevant OCPP error types.