Add v2.0.1 data types #240
Conversation
| attribute_value: str | ||
| component: ComponentType | ||
| variable: VariableType | ||
| attribute_type: Optional[enums.AttributeType] = None |
There was a problem hiding this comment.
Even if Auke was not sure on adding the custom data field, it is by default None, so it wont impact nothing if we add it and it will make it in sync with the schemas
proelke
force-pushed
the
add_v201_datatypes
branch
from
4dce8c0 to
cd58077
Compare
ocpp/v201/datatypes.py
Outdated
| full_SoC: Optional[int] = None | ||
| bulk_SoC: Optional[int] = None |
There was a problem hiding this comment.
Abbreviations in attribute names should be lower case. See for example ev_max_current.
There was a problem hiding this comment.
I was worried these wouldn't convert correctly with the weird format but I will test.
There was a problem hiding this comment.
In testing when converting to camel case the C is lowercase. I am not sure how you want to approach this edge case.
There was a problem hiding this comment.
I see your point. However, using the current implementation of snake_to_camel_case and camel_to_snake_case the conversion of bulk_SoC works only one way: from snake case to camel case.
If a CP sends a DCChargingStationParameterType to a CSMS, the CSMS will convert bulkSoC to bulk_so_c.
I suggest to introduce a map than explicitly maps bulkSoC to bulk_soc and vice versa. The functions camel_to_snake_case and snake_to_camel_case have to use this map first, before applying the regex.
There was a problem hiding this comment.
I took a slightly different approach and included some test cases. Let me know what you think.
Adding the various datatypes for v2.0.1 as I didn't see them in the repo already.