fix: use noop insights by default on maestro #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelniklasson
approved these changes
Nov 12, 2024
igorsmotto
approved these changes
Nov 12, 2024
herval
reviewed
Nov 12, 2024
| @@ -1,31 +1,20 @@ | |||
| package maestro.utils | |||
|
|
|||
| object Insights { | |||
| object Insights: InsightsInterface { | |||
There was a problem hiding this comment.
IIUC, this doesn't do anything, other than invoking a bunch of listeners. Why do you need a noop version in that case?
There was a problem hiding this comment.
The Insights are only used for CLI, the noop is default implementation that we pass for cloud versions and only override for CLI. Earlier the implementations were coupled inside Orchestra and hence the cloud code.
| @@ -0,0 +1,38 @@ | |||
| package maestro.utils | |||
|
|
|||
| interface InsightsInterface { | |||
There was a problem hiding this comment.
nit: interfaces shouldn't include "Interface" on their name.
There was a problem hiding this comment.
Good point, I'll fix this
amanjeetsingh150
force-pushed
the
MA-2534-insights-noop-impl
branch
from
159fe78 to
17c6dfe
Compare
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Insightsis a CLI-only concept. We've seen this implementation causing problems on the cloud. This PR provides a noop implementation to Insights by default so that we don't use it on cloud.For CLI the real implementation is passed so that behavior of CLI remains unchanged
Testing
Locally running a command that raises insight. Tapping on optional view that's not there.
Issues fixed