From ff7411e7b23f08f737ac0a009c2c95f60326f954 Mon Sep 17 00:00:00 2001
From: mzardab <mzardab@redhat.com>
Date: Fri, 1 Sep 2023 14:37:10 +0100
Subject: [PATCH] Some perf flags exposed via env vars: * Disabled http2 due to
 http2 streaming in net/http2 performance issues
 https://github.com/golang/go/issues/37373 * RCLONE_S3_UPLOAD_CONCURRENCY,
 RCLONE_S3_CHUNK_SIZE to improve parallelism and download efficiency

Signed-off-by: mzardab <mzardab@redhat.com>
---
 .../rclone-bucket-replicate/job-template.yaml          |  2 +-
 .../rclone-config-template.yaml                        | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/resources/operations/rclone-bucket-replicate/job-template.yaml b/resources/operations/rclone-bucket-replicate/job-template.yaml
index a407ab51378..df7f48fc2f2 100644
--- a/resources/operations/rclone-bucket-replicate/job-template.yaml
+++ b/resources/operations/rclone-bucket-replicate/job-template.yaml
@@ -74,8 +74,8 @@ objects:
                 - ${SOURCE_ENDPOINT}:${SOURCE_BUCKET}
                 - ${TARGET_ENDPOINT}:${TARGET_BUCKET}
                 - '--rc'
-                - '-v'
                 - '--rc-enable-metrics'
                 - '--rc-addr=:10902'
+                - '--s3-disable-http2' # Needed due to https://github.com/golang/go/issues/37373
           restartPolicy: Never
 
diff --git a/resources/operations/rclone-bucket-replicate/rclone-config-template.yaml b/resources/operations/rclone-bucket-replicate/rclone-config-template.yaml
index cf3c77a1e0d..c556e0ac5ec 100644
--- a/resources/operations/rclone-bucket-replicate/rclone-config-template.yaml
+++ b/resources/operations/rclone-bucket-replicate/rclone-config-template.yaml
@@ -16,11 +16,15 @@ parameters:
   - name: RCLONE_STATS_INTERVAL
     value: '30s'
   - name: RCLONE_LOG_LEVEL
-    value: '1'
+    value: '0'
   - name: RCLONE_PARALLEL_TRANSFERS
     value: '4'
   - name: RCLONE_PARALLEL_FILE_CHECKERS
     value: '8'
+  - name: RCLONE_S3_UPLOAD_CONCURRENCY
+    value: '8'
+  - name: RCLONE_S3_CHUNK_SIZE
+    value: '64M'
 
 objects:
   - apiVersion: v1
@@ -42,3 +46,7 @@ objects:
       # Checkers do the equality checking of files during a sync
       RCLONE_CHECKERS: ${RCLONE_PARALLEL_FILE_CHECKERS}
 
+      # AWS Client Specific Parameters
+      RCLONE_S3_UPLOAD_CONCURRENCY: ${RCLONE_S3_UPLOAD_CONCURRENCY}
+      RCLONE_S3_CHUNK_SIZE: ${RCLONE_S3_CHUNK_SIZE}
+