Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream our changes to PyTorch r(2+1)d architecture #5

Closed
daniel-j-h opened this issue Sep 27, 2019 · 3 comments
Closed

Upstream our changes to PyTorch r(2+1)d architecture #5

daniel-j-h opened this issue Sep 27, 2019 · 3 comments

Comments

@daniel-j-h
Copy link
Member

The torchvision r(2+1)d architecture needs two modifications to get it in sync with the official Caffe2 implementation (see facebookresearch/VMZ#89) and our provided code:

  • Number of midplanes in the downsampling blocks
  • Batchnorm

We should upstream both modifications to torchvision.

@bjuncek
Copy link

bjuncek commented Sep 27, 2019

see pytorch/vision#1265

need some discussion, but is easily done

@daniel-j-h
Copy link
Member Author

@bjuncek great, this would be sweet to have upstream! ❤️ Please consider adapting the Batchnorm blocks, too. Then the architectures are 100% in sync and weights can easily be transfered.

@daniel-j-h
Copy link
Member Author

Closing this ticket since there is nothing actionable on our end. We will follow up with you folks on vmz to upstream some of our changes when we ported the weights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants