Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Support chunked prefill with prefix cache #1

Open
wants to merge 5 commits into
base: sampling_ctrl_053p1
Choose a base branch
from

Conversation

GindaChen
Copy link
Collaborator

@GindaChen GindaChen commented Aug 14, 2024

This PR is a checkpoint of some features we want in our branch.

Support prefix caching with chunked prefill.

Testing.

  • Open 2 vllm server with --enable-prefix-caching and --enable-chunked-prefill.
  • Compare the output using the same prompt in api_client.py and see if they match.
## Server side
# Round 1: without prefix caching
sh scripts/vllm-server.sh 

# Round 2: with prefix caching
sh scripts/vllm-server.sh --enable-prefix-caching

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant