-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Build and run C++ Python tests #218
Open
DarkSharpness
wants to merge
13
commits into
mlc-ai:main
Choose a base branch
from
DarkSharpness:ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
61497f5
chore(ci): try to add unit_test ci
DarkSharpness 0e3aca3
chore(ci): minor fix
DarkSharpness 671aa79
chore(ci): minor fix
DarkSharpness ade3bee
chore(ci): minor fix
DarkSharpness 18169ea
Merge branch 'src_main' into ci
DarkSharpness ff81f14
chore(ci): support pytest without hf token
DarkSharpness ced0138
chore(ci): simplify ci
DarkSharpness 733e6ed
chore(ci): minor fix
DarkSharpness 3467f57
chore(ci): try to support multi-arch
DarkSharpness 39df3bc
chore(ci): try fix
DarkSharpness 3911674
fix: fix use of deprecated std::result_of
DarkSharpness 3d6fc8c
fix: fix use of designated initializers
DarkSharpness 5874f80
chore(ci): format and simplify
DarkSharpness File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
on: | ||
workflow_dispatch: | ||
pull_request: | ||
push: | ||
|
||
jobs: | ||
run_unit_test: | ||
name: Run unit tests on ${{ matrix.os }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- {os: ubuntu-latest, arch: x86_64} | ||
- {os: ubuntu-24.04-arm, arch: aarch64} | ||
- {os: windows-latest, arch: AMD64} | ||
- {os: macos-14, arch: arm64} | ||
- {os: macos-13, arch: x86_64,} | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
submodules: recursive | ||
|
||
- name: Set up Python 3.11 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.11 | ||
|
||
- name: Build xgrammar from source | ||
run: | | ||
echo "set(XGRAMMAR_BUILD_CXX_TESTS ON)" >> cmake/config.cmake | ||
python -m pip install --upgrade pip | ||
pip install -e . | ||
|
||
- name: Run C++ tests | ||
run: | | ||
cd build && ctest && cd .. | ||
|
||
- name: Run Python tests | ||
env: | ||
HF_TOKEN: ${{ secrets.HF_TOKEN }} | ||
if: env.HF_TOKEN != '' | ||
run: | | ||
pip install pytest | ||
pytest | ||
|
||
- name: Run Python tests without HF_TOKEN | ||
env: | ||
HF_TOKEN: ${{ secrets.HF_TOKEN }} | ||
if: env.HF_TOKEN == '' | ||
run: | | ||
pip install pytest | ||
pytest -m "not hf_token_required" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to do a
ctest --test-dir build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!