Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GenerateRangeRegex #182

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Conversation

zanderjiang
Copy link
Contributor

Resolve issue in incorrectly handling varying digits in input value, as well as optimize regex pattern for large inputs

@Ubospica
Copy link
Collaborator

Ubospica commented Feb 5, 2025

Please rebase to the latest main since we just force-pushed it. See #177 (comment) for more info.

@zanderjiang zanderjiang force-pushed the json_schema_converter branch from c089497 to 48621b6 Compare February 5, 2025 05:01
@Ubospica
Copy link
Collaborator

Ubospica commented Feb 5, 2025

@zanderjiang You can drop unnecessary commits during rebasing.

… in input value, as well as optimize regex pattern for large inputs
@Ubospica
Copy link
Collaborator

Thanks for the contribution @zanderjiang!

@Ubospica Ubospica merged commit 644416e into mlc-ai:main Feb 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants