Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test lazy character class #180

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

qeternity
Copy link
Contributor

@qeternity qeternity commented Feb 3, 2025

There is an issue with the compiler and lazy character classes.

The test I have added will raise the following exception:
RuntimeError: [12:25:32] /workspace/cpp/grammar_parser.cc:78: EBNF parse error at line 1, column 16: Expect element

@Ubospica
Copy link
Collaborator

Ubospica commented Feb 5, 2025

Hi @qeternity, thanks for the contribution! The non-greedy modifier ? should indeed be supported. We have supported it in #184. We can merge this PR given the test can pass now.

@Ubospica Ubospica merged commit f7bac2c into mlc-ai:main Feb 5, 2025
Ubospica pushed a commit that referenced this pull request Feb 5, 2025
There is an issue with the compiler and lazy character classes.

The test I have added will raise the following exception:
`RuntimeError: [12:25:32] /workspace/cpp/grammar_parser.cc:78: EBNF
parse error at line 1, column 16: Expect element`
@qeternity qeternity deleted the lazy-compile-test branch February 5, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants