Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing K-Means CSV files. Slight changes to example text. #1342

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

lindapaiste
Copy link
Contributor

@lindapaiste lindapaiste commented Apr 10, 2022

Fixes #1341.

I restored the deleted files to the kmeans folder while keeping the copies in the dbscan folder, which means that we have essentially the same files in two places. I'm not sure if this is the right approach. It keeps each example isolated, but the duplication can really blow up if we want to convert these examples to p5 or to pure JS (without d3) and need to copy the files again. We might want to think about storing CSV data in a central data folder.


image

Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree that this can start to bloat the project, but as a first step I'm happy/fine to keep our examples working in isolation.

Let's a plan for a follow up where we consider the best place to store our static files and data. It might actually be a good moment to consider where we store also our model files 😬 🙈

Thanks so much!

@joeyklee joeyklee merged commit 43781af into ml5js:main Apr 13, 2022
@lindapaiste lindapaiste deleted the fix/kmeans-csv branch May 9, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CSV file in KMeans test and D3 example.
2 participants