Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batched min p and fix spec gen sampling #1222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Batched min p and fix spec gen sampling #1222

wants to merge 1 commit into from

Conversation

awni
Copy link
Member

@awni awni commented Jan 23, 2025 •
edited
Loading

Closes #1221

@starkdmi
Copy link

Resolves top_p + temp too, right?

@awni
Copy link
Member Author

awni commented Jan 24, 2025

Yes it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath Awaiting requested review from angeloskath

@barronalex barronalex Awaiting requested review from barronalex

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with speculative decoding + min_p
2 participants
@awni @starkdmi