Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mjmlio/mjml-syntax
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0
Choose a base ref
...
head repository: mjmlio/mjml-syntax
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.0
Choose a head ref
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Mar 7, 2018

  1. Update README.md

    @ngarnier
    ngarnier authored Mar 7, 2018
    Configuration menu
    Copy the full SHA
    fd2a8c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Fix pasted HTML being detected as MJML 

    Currently, the plugin's `.tmLanguage` contains a `firstLineMatch` expression that matches any `<!doctype ...>` tag, `<mjml>` tag, or `<!php` tag. This doesn't make much sense, since MJML documents start with an `<mjml>` tag, and caused pasting a HTML document into a new file in Sublime to automatically enable the MJML syntax highlighting instead of the HTML syntax highlighting.

This change fixes the regex so that it will only match `<mjml>` tags, not tags associated with other languages.

Resolves #13

To test this, I cloned the package to my local Packages folder (i.e. the alternate installation flow described in this package's docs) and tried pasting the following snippets of code into new tabs in Sublime:

```
<!doctype html>

test test
```

and

```
<?php

echo "test test"
```

and

```
<mjml>
  <mj-body>
  </mj-body>
</mjml>
```

Before I made this change, pasting either the HTML snippet or the MJML snippets caused Sublime to select MJML syntax highlighting. After I made this change, all three snippets trigger the correct syntax highlighting (i.e. HTML, PHP, and MJML respectively).
    @ExplodingCabbage
    ExplodingCabbage committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    a4fee1c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge pull request #15 from ExplodingCabbage/fix-syntax-autodetection 

    Fix pasted HTML being detected as MJML
    @iRyusa
    iRyusa authored Mar 10, 2022
    Configuration menu
    Copy the full SHA
    40e4408 View commit details
    Browse the repository at this point in the history
Loading