Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo-tree integration explodes on invalid read of remote location #137

Closed
miversen33 opened this issue Mar 1, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working Core Issues with the Core Neo-tree Neo-tree Consumer

Comments

@miversen33
Copy link
Owner

Today I had the fun experience of my work VPN dying while trying to connect to a remote server over ssh. In that process, netman fails to read the ssh server I told it to and properly tosses an error (though maybe not the best one)

Unable to read ssh://$SERVERNAME///, received error / doesn't exist

This is good! However, it looks like something is mildly broken with how we integrate those "results" into Neo-tree as immediately after this error, we get the following failure

E5108: Error executing lua: ...re/nvim/lazy/netman.nvim/lua/netman/ui/neo-tree/init.lua:1017: bad argument #1 to 'ipairs' (table expected, got nil)
stack traceback:
        [C]: in function 'ipairs'
        ...re/nvim/lazy/netman.nvim/lua/netman/ui/neo-tree/init.lua:1017: in function 'navigate'
        ...vim/lazy/netman.nvim/lua/netman/ui/neo-tree/commands.lua:14: in function 'func'
        ...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:782: in function <...are/nvim/lazy/neo-tree.nvim/lua/neo-tree/ui/renderer.lua:780>

We need better nil handling on results within our Neo-tree integration it seems

@miversen33 miversen33 added bug Something isn't working Core Issues with the Core labels Mar 1, 2023
@miversen33 miversen33 self-assigned this Mar 1, 2023
@miversen33 miversen33 added the Neo-tree Neo-tree Consumer label Apr 4, 2023
@miversen33
Copy link
Owner Author

I'm not sure which commit this was resolved in, but it has been addressed in the #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Issues with the Core Neo-tree Neo-tree Consumer
Projects
None yet
Development

No branches or pull requests

1 participant