remove stunnel as a dep, use redis native tls #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithan
commented
Sep 24, 2021
| tempdir: Some(tempdir), | ||
| addr, | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pub fn wait(&mut self) { |
There was a problem hiding this comment.
I couldn't find anything that used this, even with different sets of features turned on, so I removed it.
|
Thanks for merging this! |
barshaul
added a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
The
opensslcode is more involved, but it is a direct translation of the gen-test-certs.sh from the redis repo used for testing. I'm betting it could be stripped down a bit but I'm not great withopensslso I just used what they did.When I put up my PR for cluster mode + TLS, I'll likely factor the
opensslcode out into a separate function that can be called from thetests/support/cluster.rsmodule, but for now I've left it all inline.I've verified it works locally on my macos machine and on github actions. Happy to incorporate any feedback you may have, my next day I'll definitely be able to work on this is Oct 8, though I may have some time before then.