Add Cmd::get, Cmd::set and remove PipelineCommands #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently possible to call `set`,`get` etc on a connection and
run the query directly but it isn't possible to create a `Cmd` struct
without running the query (except for `Pipeline`).
This adds this capability with just some small tweaks to the macro
allowing `Cmd::set("abc", 123)` to be used etc.
A simple `impl Pipeline` block will do the trick here. BREAKING CHANGE Remove any imports of PipelineCommands
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
Add some helpful logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0b314e2
It is currently possible to call
set,getetc on a connection andrun the query directly but it isn't possible to create a
Cmdstructwithout running the query (except for
Pipeline).This adds this capability with just some small tweaks to the macro
allowing
Cmd::set("abc", 123)to be used etc.af5fc36
A simple
impl Pipelineblock will do the trick here.BREAKING CHANGE
Remove any imports of PipelineCommands