Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect title on default layer #54

Closed
cvantine opened this issue Aug 7, 2018 · 2 comments
Closed

Incorrect title on default layer #54

cvantine opened this issue Aug 7, 2018 · 2 comments
Assignees
@isaisabel
Labels
bug Something isn't working

Comments

@cvantine
Copy link
Contributor

cvantine commented Aug 7, 2018 •
edited
Loading

A default layer set in nav-app/src/assets/config.json will display "new layer" rather than the title defined in the layer's JSON.

To Replicate:

  1. Copy a valid JSON layer file to attack-navigator/nav-app/src/assets/defaultLayerTest.json
  2. Set "enabled" to "true" in attack-navigator/nav-app/src/assets/config.json under "default_layer"
  3. Restart the Navigator service (unnecessary if in dev mode)
@cvantine cvantine mentioned this issue Aug 7, 2018
Merged
@jburns12 jburns12 added the bug Something isn't working label Aug 17, 2018
@jburns12
Copy link
Contributor

Hi @cvantine - thanks for bringing up this issue and for contributing our first external pull request! We will soon test and merge it into the project.

@isaisabel isaisabel self-assigned this Nov 19, 2018
@isaisabel
Copy link
Contributor

Merged fix into the develop branch. Thank you for catching the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaisabel isaisabel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jburns12 @isaisabel @cvantine