Improvement: Display a plugin's post install message if available #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ipwnstuff I like the idea :) @mitchellh what do u think about this? should it go on 1.3+ or can we add it to 1.2? |
|
Nice 👍 This would be super-helpful for those who are building plugins that are disabled by default |
|
This is great. Merging. Thanks so much! |
mitchellh
added a commit
that referenced
this pull request
Aug 9, 2013
…essage commands/plugin/install: Display a plugin's post install message if available
|
👍 |
|
You're welcome. Glad I could contribute. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks if the
Gem::Specificationwas given a post install message (spec.post_install_message = "Thanks for installing!"). If it's found it is printed to the screen usingenv[:ui].info. This helps plugins that need just a bit of extra set up explaint to the user. See my latest pull request on Bindler fgrehm/bindler#14.