You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I would like to bump Ariadne to the same standard as other projects we maintain, take Smyth for an example.
Now what is that standard? Basically I would like to leverage hatch in all it's glory that would entail changes in the pyproject.toml file with following outcomes:
Black and pylint would be dropped in favor of Ruff
There will be Hatch environments for types, tests and linting - scripts will not be run of the default environment
For tests and linting Hatch's build-in envs will be used
Mypy will get explicit configuration in pyproject.toml
Coverage will get explicit configuration in pyproject.toml
Ruff will get explicit configuration in pyproject.toml
Will try to set Ruff to follow to current style of Ariadne's code but a "style" commit might happen
A switch to absolute imports is to be discussed here
There would be a change in the release tooling and GitHub actions to the ones present in Smyth.
Rationale behind this
First of all, we are not utilizing the tooling useful tooling provided by hatch that is already in use. Second, there is no explicit configuration of tests and linters which makes them yield different results on different versions of the underlying tools. Third, internally, we need the consistency between the projects we maintain to move faster and not waste time on the discovery of tooling surrounding the project.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi, I would like to bump Ariadne to the same standard as other projects we maintain, take Smyth for an example.
Now what is that standard? Basically I would like to leverage hatch in all it's glory that would entail changes in the pyproject.toml file with following outcomes:
There would be a change in the release tooling and GitHub actions to the ones present in Smyth.
Rationale behind this
First of all, we are not utilizing the tooling useful tooling provided by hatch that is already in use. Second, there is no explicit configuration of tests and linters which makes them yield different results on different versions of the underlying tools. Third, internally, we need the consistency between the projects we maintain to move faster and not waste time on the discovery of tooling surrounding the project.
Here's the proposed change: #1221
Any thoughts?
Beta Was this translation helpful? Give feedback.
All reactions