From a408ef3aa9ccfb331948d0543464eb36f4aa021e Mon Sep 17 00:00:00 2001 From: Arun Kumar Madesh <56151567+arunkumar461@users.noreply.github.com> Date: Sat, 4 Jan 2025 21:26:55 +0000 Subject: [PATCH] CCMSPUI-468 | Add more tests --- .../ccms/springboot/dialect/DatePickerAttributes.java | 2 +- .../dialect/MoJDatePickerElementTagProcessorTest.java | 11 ++++++++++- .../src/test/resources/templates/test-datepicker.html | 10 ++++++++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java index fb07a90..8451b17 100644 --- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java +++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/main/java/uk/gov/laa/ccms/springboot/dialect/DatePickerAttributes.java @@ -14,6 +14,6 @@ public record DatePickerAttributes( String maxDate) { public boolean hasError() { - return !errorMessage.isEmpty(); + return errorMessage != null && !errorMessage.isBlank(); } } diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java index 192e816..2bf11e5 100644 --- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java +++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/java/uk/gov/laa/ccms/springboot/dialect/MoJDatePickerElementTagProcessorTest.java @@ -29,7 +29,16 @@ void shouldRenderGovukButton() { "Please enter a valid date of birth.

" + - ""); + "") + .contains( + "
" + + "
For example, 01/01/2000.
"); } diff --git a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html index 43dd98e..25c0a63 100644 --- a/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html +++ b/laa-ccms-spring-boot-starters/laa-ccms-spring-boot-starter-govuk-dialect/src/test/resources/templates/test-datepicker.html @@ -16,5 +16,15 @@ value="2024-01-01"> + + + \ No newline at end of file