Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python-magic an optional dependency? #254

Closed
satya-waylit opened this issue Oct 18, 2024 · 2 comments
Closed

Make python-magic an optional dependency? #254

satya-waylit opened this issue Oct 18, 2024 · 2 comments

Comments

@satya-waylit
Copy link

Looks like #82 removed a hard dependency on python-magic. Would it be appropriate to make it an optional dependency? This would allow installation on Windows. I'm happy to make a PR if so.

@mindflayer
Copy link
Owner

Hi @satya-waylit, I spent some time investigating alternatives and I found out there is a pure-Python implementation of magic. From now on Mocket will rely on it.

@mindflayer
Copy link
Owner

Here it is: https://pypi.org/project/mocket/3.13.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants