Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refreshing properties by both upstream ID and name doesn't work #4431

Closed
jhrozek opened this issue Sep 10, 2024 · 0 comments · Fixed by #4432
Closed

refreshing properties by both upstream ID and name doesn't work #4431

jhrozek opened this issue Sep 10, 2024 · 0 comments · Fixed by #4432
Assignees
@jhrozek
Labels
bug Something isn't working P0 Fix Now: These are urgent issues that preempt other work in the current sprint

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Sep 10, 2024

We recently enhanced the property service to include lookup by ID in the cache, which is great, but we didn't handle the case where the lookup properties included the upstream ID but the entity properties in the database did not. In that case we should fall back to looking the property by name.
@jhrozek jhrozek added bug Something isn't working P0 Fix Now: These are urgent issues that preempt other work in the current sprint labels Sep 10, 2024
@jhrozek jhrozek self-assigned this Sep 10, 2024
@jhrozek jhrozek mentioned this issue Sep 10, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhrozek jhrozek

Labels
bug Something isn't working P0 Fix Now: These are urgent issues that preempt other work in the current sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix retrieving properties by upstream ID and name jhrozek/minder
1 participant
@jhrozek