Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails due to dangling comment #17

Closed
matteo-gsr opened this issue Jan 9, 2025 · 4 comments
Closed

Build fails due to dangling comment #17

matteo-gsr opened this issue Jan 9, 2025 · 4 comments

Comments

@matteo-gsr
Copy link
Collaborator

matteo-gsr commented Jan 9, 2025

Hey Mo,

Seems like the build fails due to that dangling comment in the cluster tool. Can you perhaps avoid building aeron-all and only build the aeron-archive, aeron-client, aeron-media-driver targets?

-- Found Threads: TRUE
  -- Looking for fallocate
  -- Looking for fallocate - not found
  -- Looking for posix_fallocate
  -- Looking for posix_fallocate - not found
  -- Looking for F_PREALLOCATE
  -- Looking for F_PREALLOCATE - found
  -- Found Java: /Users/matteo/Library/Java/JavaVirtualMachines/openjdk-23.0.1/Contents/Home/bin/java (found version "23.0.1")
  -- Configuring done (2.9s)
  -- Generating done (0.1s)
<redacted>
  [  2%] Generating aeron-all jar
  --- stderr
  /Users/matteo/.cargo/registry/src/<redacted>-92008fde37d01c13/rusteron-archive-0.1.47/aeron/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java:600: warning: [dangling-doc-comments] documentation comment is not attached to any declaration
      ///////////////////////////////////////////////////////
      ^
  error: warnings found and -Werror specified
  1 error
  1 warning
  FAILURE: Build failed with an exception.
  * What went wrong:
  Execution failed for task ':aeron-cluster:compileJava'.
  > Compilation failed; see the compiler output below.
    error: warnings found and -Werror specified
    /Users/matteo/.cargo/registry/src/<redacted>-92008fde37d01c13/rusteron-archive-0.1.47/aeron/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java:600: warning: [dangling-doc-comments] documentation comment is not attached to any declaration
        ///////////////////////////////////////////////////////
        ^
    1 error
    1 warning
  * Try:
  > Check your code and dependencies to fix the compilation error(s)
  > Run with --scan to get full insights.
  BUILD FAILED in 12s
  uuid lib not found in path
  CMake Warning:
    Manually-specified variables were not used by the project:
      CMAKE_ASM_COMPILER
      CMAKE_ASM_FLAGS
  make: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
  /Users/matteo/.cargo/registry/src/<redacted>-92008fde37d01c13/rusteron-archive-0.1.47/aeron/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java:600: warning: [dangling-doc-comments] documentation comment is not attached to any declaration
      ///////////////////////////////////////////////////////
      ^
  error: warnings found and -Werror specified
  1 error
  1 warning
  FAILURE: Build failed with an exception.
  * What went wrong:
  Execution failed for task ':aeron-cluster:compileJava'.
  > Compilation failed; see the compiler output below.
    error: warnings found and -Werror specified
    /Users/matteo/.cargo/registry/src/<redacted>-92008fde37d01c13/rusteron-archive-0.1.47/aeron/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java:600: warning: [dangling-doc-comments] documentation comment is not attached to any declaration
        ///////////////////////////////////////////////////////
        ^
    1 error
    1 warning
  * Try:
  > Check your code and dependencies to fix the compilation error(s)
  > Run with --scan to get full insights.
  BUILD FAILED in 5s
  make[3]: *** [/Users/matteo/.cargo/registry/src/<redacted>-92008fde37d01c13/rusteron-archive-0.1.47/aeron/aeron-all/build/libs/aeron-all-1.47.0-SNAPSHOT.jar] Error 1
  make[2]: *** [CMakeFiles/aeron-all-jar.dir/all] Error 2
  make[1]: *** [aeron-archive/src/main/c/CMakeFiles/aeron_archive_c_client.dir/rule] Error 2

By the way, this is only happening if you are on the latest jdk (23).

@matteo-gsr matteo-gsr changed the title Build fails to dangling comment Build fails due to dangling comment Jan 9, 2025
@mimran1980
Copy link
Owner

Seems to be getting called by cmake files from aeron. I think the change will need to be done on the aeron side

@matteo-gsr
Copy link
Collaborator Author

see aeron-io/aeron#1710

@matteo-gsr
Copy link
Collaborator Author

@mimran1980 - can you update aeron? They fix is in upstream now.

@mimran1980
Copy link
Owner

mimran1980 commented Jan 13, 2025

@matteo-gsr Thanks for raising that. If you use 0.1.55 that should now work resolve the issue. I updated the ci to also use jdk 23 to confirm it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants