Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lastResponseHeaders #183

Merged
merged 1 commit into from
Nov 20, 2013
Merged

Added lastResponseHeaders #183

merged 1 commit into from
Nov 20, 2013

Conversation

AlgoTrader
Copy link
Contributor

There is often need to extract cookies from a successful SOAP invocaton. Now I have to patch node-soap to do it. This pull request fixes (or at least much eleviates) issue 137 also, it is not only me who need access to HTTP headers of the last request.

There is often need to extract cookies from a successful SOAP invocaton. Now I have to patch node-soap to do it. This pull request fixes (or at least much eleviates) issue 137 also, it is not only me who need access to HTTP headers of the last request.
@shanestillwell
Copy link

I really need access to the lastResponseHeaders to allow Cookie Authentication with the SOAP services I'm interacting with. Anything blocking this pull-request from being merged?

I've published an NPM module that uses the cookie as a security method.
https://npmjs.org/package/soap-cookie

Thanks!

milewise added a commit that referenced this pull request Nov 20, 2013
@milewise milewise merged commit 396adcb into vpulim:master Nov 20, 2013
@AlgoTrader AlgoTrader deleted the patch-1 branch November 21, 2013 06:08
@joewils
Copy link

joewils commented Nov 27, 2013

Has this change been published to npm? It looks like the last publish date on npm is a month older than master.
https://npmjs.org/package/soap

@shanestillwell
Copy link

It's been merged into master, but not published to NPM yet that I can see.

If you need this change you can just use this your package.json

    "soap": "git://github.com/milewise/node-soap.git",

@milewise
Copy link
Collaborator

published to NPM as version 0.3.1

@joewils
Copy link

joewils commented Nov 27, 2013

Thanks for the tip @shanestillwell and thank you @milewise for publishing to NPM so quickly.

diarmaidm pushed a commit to diarmaidm/node-soap that referenced this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants