Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhoc: Remove the Initialize method from the DataEntityDataReader. #673

Closed
mikependon opened this issue Dec 13, 2020 · 0 comments
Closed
Assignees
Labels
adhoc An adhoc thinking that is good to be incorporated deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed.

Comments

@mikependon
Copy link
Owner

As part of the fixes made to the #668, the Initialize() method within the DataEntityDataReader class seems to be not important anymore (and has been invalidated).

With the fix we introduced on the mentioned issue, we tend to eliminate the logic that filters the list of the DB Fields if being compared to the fields of the Data Entity as it is really possible that they are not equal, but the users/callers can still pass the list of mappable fields via mappings attribute.

Many thanks to @SpaceOgre for pushing and letting us realized this.

@mikependon mikependon added adhoc An adhoc thinking that is good to be incorporated fixed The bug, issue, incident has been fixed. labels Dec 13, 2020
@mikependon mikependon self-assigned this Dec 13, 2020
@mikependon mikependon added the deployed Feature or bug is deployed at the current release label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc An adhoc thinking that is good to be incorporated deployed Feature or bug is deployed at the current release fixed The bug, issue, incident has been fixed.
Projects
None yet
Development

No branches or pull requests

1 participant