Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: Review the Cursor Pagination Implementation and assess the other DB Providers #634

Open
mikependon opened this issue Nov 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikependon
Copy link
Owner

The implementation of Cursor Pagination from this code base is quite awesome.

This story will allow us to consider the implementation to be integrated to the core library (RepoDb) or the official extension for SQL Server (RepoDb.SqlServer) if needed/possible. In addition, this User Story is used as a placeholder for Cursor Pagination via other DB Provider (i.e.: MySQL, PostgreSQL and SQLite).

Note: An additional User Stories will be created if needed in order for us to fully integrate the solution to the core library.

Ensure the author of this extension library is notified.

@mikependon mikependon added the enhancement New feature or request label Nov 1, 2020
@mikependon mikependon self-assigned this Nov 1, 2020
@cajuncoding
Copy link
Collaborator

@mikependon this is great, thank you so much for the complement on my repo!

In fact you have already read my mind. I wanted to ping you soon about the inclusion of the cursor pagination into the core of RepoDb!

I was just waiting to iron out a few more issues/concepts before proposing it.

I'd be happy to create a draft PR over the next couple of weeks if you would like that, or whatever next steps you think would be best.

@chopswil15
Copy link

The implementation of Cursor Pagination from this code base is quite awesome.

This story will allow us to consider the implementation to be integrated to the core library (RepoDb) or the official extension for SQL Server (RepoDb.SqlServer) if needed/possible. In addition, this User Story is used as a placeholder for Cursor Pagination via other DB Provider (i.e.: MySQL, PostgreSQL and SQLite).

Note: An additional User Stories will be created if needed in order for us to fully integrate the solution to the core library.

Ensure the author of this extension library is notified.

the link "code base" is broken

@mikependon
Copy link
Owner Author

That is because @cajuncoding, the author of the extension library renamed the repository due to GraphQL request. The new code base is found here.

@cajuncoding
Copy link
Collaborator

Sorry about that broken link, I had to rename by request from the HotChocolate core team...they want to keep any other uses of their namespace out of Nuget so renaming GitHub was also needed for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants