Empty response body (3-rd argument) must be passed to callback as an empty string #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeal
added a commit
that referenced
this pull request
Mar 25, 2013
Empty response body (3-rd argument) must be passed to callback as an empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs sates: "The callback argument gets 3 arguments. ... The third is the response body String or Buffer."
If response has an empty body (Content-length is 0) third argument is
undefined, notStringnorBuffer.The "edge case" is JSON response. Empty body can't be parsed to something convinient, so, this case still results in
undefined(may be it must be handled different way?).