Correct Host header for proxy tunnel CONNECT #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC 2817, section 5.2 Requesting a Tunnel with CONNECT, there is a
Host
header to be set. The examples in the RFC use the same example host/port which is confusing, but logically, it makes no sense to use the same hostname inCONNECT
statement and in theHost
header. TheHost
header is meant to be set to the actual host to be proxied/tunelled to, and it looks like at least some of the proxies out there work that way.I believe this also closes #367.
Notes:
opts = { tunnelOptions: { .. } }