Running rfc3986 on base_uri in oauth.hmacsign instead of just encodeURIComponent
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codeURIComponent. Essentially, all I've really changed in terms of output is that the base_uri is encoded with the rfc3986 function before being included in the sha1 base. I was getting 401 errors with the LinkedIn API because my signatures were wrong when I used [field selectors](https://developer.linkedin.com/documents/field-selectors) in an api call.
mikeal
added a commit
that referenced
this pull request
Nov 5, 2012
Running `rfc3986` on `base_uri` in `oauth.hmacsign` instead of just `encodeURIComponent`
|
the oauth test no longer passes :( |
|
if i don't get a fix in the next few hours i'm going to have to back this out. |
|
Ok, I'll have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All I've changed in terms of output is that the base_uri is encoded with the rfc3986 function before being included in the sha1 base. I was getting 401 errors with the LinkedIn API because my signatures were wrong when I used field selectors in an api call.