Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't create a cookie in a wrapped request (defaults) #170

Merged
merged 1 commit into from
Feb 12, 2012

Conversation

fabianonunes
Copy link
Contributor

when the request object is a wrapped defaults, creating a cookie throws a expection

var cookie = request.cookie( 'your_cookie_here' )
Error: The cookie function only accepts STRING as param

the 'cookie' method only accepts a string, but the wrapped request transforms any params in { uri:opts }

if (typeof opts === 'string') opts = {uri:opts}

mikeal added a commit that referenced this pull request Feb 12, 2012
can't create a cookie in a wrapped request (defaults)
@mikeal mikeal merged commit 05e1c78 into request:master Feb 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants