Fixed cookies parsing

[afanasy]

• correct handling of cookies values with equal sign (sid="c2lkDQo=")
• improved default path parsing
• updated tests

[mikeal]

i'd like some eyes on this who've been in this code, I haven't spent enough time in in it.

@jhurliman @janjongboom @alessioalex

[afanasy]

I've added comments

[pinakin-ezee]

Hi.

I'm not sure if this is related but the new version of request does not appear to handle cookies correctly. Or rather, not as well as it used to. After spending a morning trying to work out why some previously working code had stopped functioning I narrowed it down to the header information sent and saw that the cookie I was sending appeared to be undefined. I am now using an old version of request (not sure which version it is but I installed it 18/11/2011) and that works correctly.

var sessionId = "EFFCBC5DF5D12EEF44BFECB81B58C221.86922E30DDA32934988F2834DFC92B";
var cookieStr = "sessionID=" + sessionId;

var headerData = {"Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8",
                  "Accept-Language":"en-us",
                  "Origin":"http://www.xxxxxxxx.com",
                  "Referer":"http://www.xxxxxxxx.com/home",
                  "User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/534.51.22 (KHTML, like Gecko) Version/5.1.1 Safari/534.51.22",
                  "Cookie":cookieStr};

var options = {uri:headingUri, headers:headerData};

request.get(options, function (error, response, body) {

[mikeal]

latest release or master?

[afanasy]

So what's up with this request? Its kind of fixes a major bug.

[pinakin-ezee]

The latest release (the version one gets with "npm install request"). The weird thing is I tested this version with a simple php file that reads header data and all appeared fine, including cookies. It's just that the response coming back for the code mentioned above indicates that I am send an "undefined" sessionid (a cookie) but with the older version of request the response shows the correct sessionid sent.

[mikeal]

pushed new version with this fix in it.

[afanasy]

great, thanks!