Remove instanceof check for CookieJar (mikeal suggestion)

request · Nov 13, 2011 · 366831b · 366831b
1 parent fc44260
commit 366831b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/main.js b/main.js
@@ -140,10 +140,7 @@ Request.prototype.request = function () {
     setHost = true
   }
 
-  // if user tries to define a bad cookie jar
-  if (self.jar && !(self.jar instanceof CookieJar)) {
-    throw new Error("Argument error, options.jar.")
-  } else if (self.jar) {
+  if (self.jar) {
     // fetch cookie from the user defined cookie jar
     var cookies = self.jar.get({ url: self.uri.href })
   } else {

diff --git a/tests/test-errors.js b/tests/test-errors.js
@@ -20,13 +20,6 @@ try {
   assert.equal(e.message, 'Argument error, options.multipart.')
 }
 
-try {
-  request({uri:local, jar: 'foo'})
-  assert.fail("Should have throw")
-} catch(e) {
-  assert.equal(e.message, 'Argument error, options.jar.')
-}
-
 try {
   request({uri:local, multipart: [{}]})
   assert.fail("Should have throw")