From 7c1a8f7d010801c5694af4aad02def7f21e38f5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miko=C5=82aj=20Adamczyk?= Date: Tue, 20 Mar 2018 11:08:35 +0100 Subject: [PATCH] EZP-28945: User will be able to search for content items by just selecting the filters. --- src/bundle/Controller/SearchController.php | 13 +++++++++---- src/lib/Form/Data/Search/SearchData.php | 6 +----- src/lib/Form/Type/Search/SearchType.php | 2 +- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/bundle/Controller/SearchController.php b/src/bundle/Controller/SearchController.php index f04370dc60..69780ba2e4 100644 --- a/src/bundle/Controller/SearchController.php +++ b/src/bundle/Controller/SearchController.php @@ -129,9 +129,11 @@ public function searchAction(Request $request): Response $lastModified = $data->getLastModified(); $created = $data->getCreated(); $query = new Query(); - $criteria = [ - new Criterion\FullText($queryString), - ]; + $criteria = []; + + if (null !== $queryString) { + $criteria[] = new Criterion\FullText($queryString); + } if (null !== $section) { $criteria[] = new Criterion\SectionId($section->id); } @@ -152,7 +154,10 @@ public function searchAction(Request $request): Response [$created['start_date'], $created['end_date']] ); } - $query->filter = new Criterion\LogicalAnd($criteria); + if (!empty($criteria)) { + $query->filter = new Criterion\LogicalAnd($criteria); + } + $query->sortClauses[] = new SortClause\DateModified(Query::SORT_ASC); $pagerfanta = new Pagerfanta( diff --git a/src/lib/Form/Data/Search/SearchData.php b/src/lib/Form/Data/Search/SearchData.php index 00a0ee72f5..759bf396c0 100644 --- a/src/lib/Form/Data/Search/SearchData.php +++ b/src/lib/Form/Data/Search/SearchData.php @@ -25,11 +25,7 @@ class SearchData /** @var int */ private $page; - /** - * @var string - * - * @Assert\NotBlank() - */ + /** @var string */ private $query; /** @var \eZ\Publish\API\Repository\Values\Content\Section */ diff --git a/src/lib/Form/Type/Search/SearchType.php b/src/lib/Form/Type/Search/SearchType.php index ea3a43038b..1a676108e3 100644 --- a/src/lib/Form/Type/Search/SearchType.php +++ b/src/lib/Form/Type/Search/SearchType.php @@ -33,7 +33,7 @@ public function __construct(TranslatorInterface $translator) public function buildForm(FormBuilderInterface $builder, array $options) { $builder - ->add('query', CoreSearchType::class) + ->add('query', CoreSearchType::class, ['required' => false]) ->add('page', HiddenType::class) ->add('limit', HiddenType::class) ->add('section', SectionChoiceType::class, [