-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet balance, updatetag failing due to invalid HTML parsing algorithm #99896
Labels
bug
Issue identified by VS Code Team member as probable bug
emmet
Emmet related issues
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Milestone
Comments
OliverJAsh
changed the title
Emmet "split/join tag" does not work if file contains some characters
Emmet "split/join tag" and "update tag" do not work if file contains some characters
Jul 8, 2020
Updated issue to mention that this also effects other commands. |
OliverJAsh
changed the title
Emmet "split/join tag" and "update tag" do not work if file contains some characters
Emmet tag commands do not work if file contains some characters
Jul 8, 2020
Interested in working on this, will be picking it up |
The current parser in util.ts is trying to parse f as its own tag, and so I think it needs to be updated. Another instance of this issue is #73415 |
rzhao271
changed the title
Emmet tag commands do not work if file contains some characters
Emmet tag commands failing due to invalid HTML parsing algorithm
Nov 17, 2020
This was referenced Nov 17, 2020
rzhao271
changed the title
Emmet tag commands failing due to invalid HTML parsing algorithm
Emmet balance, updatetag failing due to invalid HTML parsing algorithm
Nov 17, 2020
This was referenced Dec 14, 2020
Verifier:
import React from 'react';
// <f
const MyComponent = () => <div className="foo">Hello, World</div>;
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
emmet
Emmet related issues
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Steps to Reproduce:
tsx
file with this content:div
and run any one of these commands:Expected: the command should work
Actual: the command does nothing
If we remove the comment that contains
<f
, it works.Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: