Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM does not work with RHEL 6.7 #9487

Closed
jsloyer opened this issue Jul 19, 2016 · 8 comments
Closed

RPM does not work with RHEL 6.7 #9487

jsloyer opened this issue Jul 19, 2016 · 8 comments
Assignees
Labels
help wanted Issues identified as good community contribution opportunities linux Issues with VS Code on Linux

Comments

@jsloyer
Copy link

jsloyer commented Jul 19, 2016

The RPM for RHEL 6.7 x64 does not work as it fails dependency checks. The spec file for the rpm specifies glibc >= 2.15 while 2.12 is the latest thats available in RHEL 6. I'll be opening a PR for the fix...

/cc @davebachmann

@jsloyer
Copy link
Author

jsloyer commented Jul 19, 2016

PR #9488 submitted with the fix

@Tyriar Tyriar self-assigned this Jul 19, 2016
@Tyriar Tyriar added the linux Issues with VS Code on Linux label Jul 19, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2016

This check was added as RHEL 6 did not work, at least when built on our build system. This check is better than the ambiguous error that follows without it on distros derived from red hat 6.

You can see #3603 and #1056 for some back story on this, as well as our requirements page https://code.visualstudio.com/docs/supporting/requirements

@jsloyer
Copy link
Author

jsloyer commented Jul 19, 2016

@Tyriar is there any reason why you need 2.15 of glibc instead of 2.12?

@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2016

@jsloyer that requirement was there before I joined the team so I'm not sure exactly. All my testing running on the latest RHEL6 at the time crashed vscode immediately. Are you running it on RHEL 6.7 without any problems?

@davebachmann
Copy link

@Tyriar it appears to be wanting a newer version of libnotify than RHEL 6.7 has so is not starting.
error while loading shared libraries: libnotify.so.4: cannot open shared object file: No such file or directory

I only have libnotify.so.1 from libnotify.x86_64 0.5.0-1.el6

@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2016

@davebachmann unfortunately I don't have cycles to invest in this. PRs are welcome if you can improve compatibility with RHEL6, I don't think just downgrading the glibc dep version will be enough though.

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 19, 2016
@jsloyer
Copy link
Author

jsloyer commented Jul 19, 2016

Myself and @davebachmann are looking into it.

@jsloyer
Copy link
Author

jsloyer commented Jul 22, 2016

@Tyriar it seems vscode depends on libnotify4 but its not called out as a dep, I couldn't find a reference to it in the code base except in the debian build file.

@jsloyer jsloyer closed this as completed Jul 25, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues identified as good community contribution opportunities linux Issues with VS Code on Linux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants