Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cross file undo (when file name changes?) #91380

Closed
jrieken opened this issue Feb 25, 2020 · 1 comment
Closed

No cross file undo (when file name changes?) #91380

jrieken opened this issue Feb 25, 2020 · 1 comment
Assignees
Labels
undo-redo Issues around undo/redo

Comments

@jrieken
Copy link
Member

jrieken commented Feb 25, 2020

re #91248

  • open java-8 dev container
  • in AppTest.java add a reference to App
  • open both files side by side, reload
  • rename App to App3
  • undo
  • 🐛 only one editor is undone, no message, no x-file undo
@alexdima alexdima added the undo-redo Issues around undo/redo label Feb 26, 2020
@alexdima alexdima changed the title No x-file undo (when file name changes?) No cross file undo (when file name changes?) Feb 26, 2020
@alexdima
Copy link
Member

@jrieken I am seeing a notification when undoing. This seems to be the same case as #91379 or is perhaps a duplicate of #77190 , since the rename is not limited to textual changes, it also includes a file rename:

Kapture 2020-02-26 at 16 47 52

I am sorry I should have probably specified better what is implemented. We now support cross-file undo of textual edits if the text buffers have not been disposed in the meantime. I did not implement undo for file edits, that still needs to be implemented.

I suggest to continue tracking in #77190

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
undo-redo Issues around undo/redo
Projects
None yet
Development

No branches or pull requests

2 participants