Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide API vscode.env.openItem #88273

Closed
tjx666 opened this issue Jan 8, 2020 · 2 comments
Closed

provide API vscode.env.openItem #88273

tjx666 opened this issue Jan 8, 2020 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) uri

Comments

@tjx666
Copy link
Contributor

tjx666 commented Jan 8, 2020

openExternal doesn't work when file path contains non-ascii chars.
reference issues: electron/electron#6302

I'm working with my extension open-in-external-app, but I found that the following code doesn't work when the filePath contains non-ascii chars.

vscode.env.openExternal(vscode.Uri.file(filePath));

for example: vscode.env.openExternal(vscode.Uri.file('C:/测试.md'));
It works well when filePath only includes ascii chars. Is there any methods to fix it, or provide the API vscode.env.openItem as electron?

@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) uri labels Jan 8, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 8, 2020

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jan 8, 2020
@jrieken
Copy link
Member

jrieken commented Jan 8, 2020

#85930

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) uri
Projects
None yet
Development

No branches or pull requests

2 participants