Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semantic tokens] The concept of "-" minus feels weird #86282

Closed
alexdima opened this issue Dec 4, 2019 · 1 comment
Closed

[semantic tokens] The concept of "-" minus feels weird #86282

alexdima opened this issue Dec 4, 2019 · 1 comment
Assignees
Labels
editor-theming Issues related to the way themes are applied to editors semantic-tokens Semantic tokens issues
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Dec 4, 2019

Testing #85972

The concept of removing a fontStyle is super weird.

For example:

"*.static": {
  "fontStyle": "italic"
},
"*.abstract": {
  "fontStyle": "underline-italic"
}

image

That just reads as if I asked for underline and italic, but it means underline, remove italic if set. IMHO this is super complex and foreign coming from TM grammars / CSS styling...

@alexdima
Copy link
Member Author

alexdima commented Dec 4, 2019

Also, the none appears to be broken:
image

        "*.static": {
            "fontStyle": "italic"
        },
        "*.abstract": {
            "fontStyle": ""
        },

image

@aeschli aeschli added semantic-tokens Semantic tokens issues editor-theming Issues related to the way themes are applied to editors labels Dec 5, 2019
@aeschli aeschli changed the title The concept of "-" minus feels weird [semantic tokens] The concept of "-" minus feels weird Dec 5, 2019
@aeschli aeschli added this to the Backlog milestone Dec 5, 2019
@aeschli aeschli modified the milestones: Backlog, January 2020 Jan 14, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-theming Issues related to the way themes are applied to editors semantic-tokens Semantic tokens issues
Projects
None yet
Development

No branches or pull requests

2 participants