-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[semantic tokens] Use singular for token type names #86281
Comments
It's more related to styling I chose plural as we already have the setting
and my goal is to bring this together. |
I see how this was driven, and in the coloring context that makes sense: "I want to color comments in red". But I still think writing a parser and returning plurals is very different than what I have seen/done so far. Could we look at some language ASTs, is anyone using plurals? |
The token names are not user facing, while the settings are. So while I agree that plurals are unconventional and even a bit weird, are not a real problem. That said, deprecating the current setting names is also possible. |
@aeschli Two final points.
<div class="title">Title 1</div>
<div class="content">Content 1</div>
<div class="title">Title 2</div>
<div class="content">Content 2</div> The CSS is .title { color: red } |
Making the change as we want to mention the new API in the release notes so that others can try it out. |
Testing #85972
I have written quite a number of parsers, and so far I never used terms like this is "comments", this is "classes", etc.
I find the choice to use plurals in built-in token types a bit surprising.
The text was updated successfully, but these errors were encountered: