Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] auto rename doesn't exit when deleting at the end of a tag #86149

Closed
rebornix opened this issue Dec 3, 2019 · 1 comment
Closed

[html] auto rename doesn't exit when deleting at the end of a tag #86149

rebornix opened this issue Dec 3, 2019 · 1 comment
Assignees
@octref
Labels
*as-designed Described behavior is as designed

Comments

@rebornix
Copy link
Member

rebornix commented Dec 3, 2019

Testing #85973

<html>
    <foo class=this>

    </foo>
</html>
  • put cursor at the end of /foo of line 4
  • press Delete (delete the right side character)
  • keep deleting
  • auto rename mode doesn't exit
@octref
Copy link
Contributor

octref commented Dec 5, 2019

This is a really niche case...In this case there's no onSelectionChange event since your cursors didn't move. I think it's ok to leave it as it is.

@octref octref closed this as completed Dec 5, 2019
@octref octref added the *as-designed Described behavior is as designed label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebornix @octref