Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token theming: Last rule wins? #86095

Closed
chrmarti opened this issue Dec 3, 2019 · 1 comment
Closed

Token theming: Last rule wins? #86095

chrmarti opened this issue Dec 3, 2019 · 1 comment
Assignees

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Dec 3, 2019

Testing #85972

With the rules:

		"*.async": {
			"fontStyle": "bold italic"
		},
		"*.declaration": {
			"fontStyle": "-bold -italic"
		},

It appears the last one wins except when changing the order of the two rules.

Dec-03-2019 16-10-07

@aeschli
Copy link
Contributor

aeschli commented Oct 13, 2020

Yes, the last rule should win if two rules are equally strong.

The issue that you see has to do that we rely on the property order.
The configuration service does not send a change event if all that changes is the property order.
Using the property order is a bit of a gray area, so I suggest we leave things as they are and live with the issue.

@aeschli aeschli closed this as completed Oct 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants