Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply excludes to editor history quick open too #6502

Closed
vsccarl opened this issue May 18, 2016 · 5 comments
Closed

Apply excludes to editor history quick open too #6502

vsccarl opened this issue May 18, 2016 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Milestone

Comments

@vsccarl
Copy link

vsccarl commented May 18, 2016

  • VSCode Version: 1.1.0-alpha
  • OS Version: Windows 10

Related #3615

Steps to Reproduce:

I'm working in the smoke test repo (link)

  1. Use quick open Ctrl+P to open some files in node_modules folder (I just used index.js as it occurs a lot)
  2. Add in settings
"search.exclude": {
    "**/node_modules": true
}
  1. Use Ctrl+P type 'index.js'

The list of recent files still includes files located in /node_modules. I found a previous thread that says using Ctrl+K W will remove them, but excluding them in user settings should also apply to recently opened files without having to use a command to close/remove them.

@vsccarl vsccarl added file-explorer Explorer widget issues v-test labels May 18, 2016
@bpasero bpasero changed the title Quick open includes recent files that are excluded in user settings Apply excludes to editor history quick open too May 19, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label May 19, 2016
@bpasero bpasero added this to the Backlog milestone May 19, 2016
@bpasero bpasero self-assigned this May 19, 2016
@bpasero
Copy link
Member

bpasero commented May 19, 2016

We should apply the excludes to the editor history too.

@ChuckJonas
Copy link

+1 on fixing this...

@ChuckJonas
Copy link

I was very committed to using VS Code (authored 3 plugins for apex development and contributed to a 4th) but I'm sad to say abandoning it for now...

This bug killing my productivity (even caused me to introduce a production bug) and there is no viable work around.

Once you open an search excluded file, it will always seem to pop-up ahead of search included files. Even, if I exclude the file from the project, it still shows up.

@bpasero
Copy link
Member

bpasero commented Jan 19, 2017

@ChuckJonas as a workaround there is a command "Clear Editor History" (removes all) and "Remove from Editor History" to remove an individual entry.

@Xerillio
Copy link

@bpasero Thanks for the workaround, I just bumped into this issue in v.1.17.1
I see this issue has been closed, so is there no plan to apply the exclude setting on the history?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

5 participants