Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to disable excludes in quickopen #59982

Closed
nesl247 opened this issue Oct 4, 2018 · 10 comments
Closed

Button to disable excludes in quickopen #59982

nesl247 opened this issue Oct 4, 2018 · 10 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues

Comments

@nesl247
Copy link

nesl247 commented Oct 4, 2018

In PhpStorm, WebStorm, etc. the ability to search for a file, object, etc. does not limit you to only non-excluded files.

image

As you can see, there is the "Include non-project items" checkbox. This is never checked by default. It would be great if VS Code implemented this feature. By default, we don't want to show classes from composer libraries for example, but we do need to be able to search them on occasion.

This should be added for symbol and file search.

@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 4, 2018
@nesl247 nesl247 changed the title Search package manager dependencies in file pallet Search package manager dependencies in file palette Oct 4, 2018
@roblourens roblourens added the feature-request Request for new features or functionality label Oct 4, 2018
@roblourens
Copy link
Member

We have considered a toggle button for whether to apply the exclude settings

@roblourens roblourens changed the title Search package manager dependencies in file palette Button to disable excludes in quickopen Oct 4, 2018
@nesl247
Copy link
Author

nesl247 commented Oct 4, 2018

Please make it work like Jetbrain's dialog though in that if you press the same combination again, it triggers the checkbox.

@skprabhanjan
Copy link
Contributor

@roblourens , can I work on this? :)
If so can you give me some starter points before starting this ?
Thanks!

@roblourens
Copy link
Member

I think this needs some ux work and discussion on our side, I'm not really convinced it's needed.

@roblourens
Copy link
Member

But thanks for your enthusiasm :)

@nesl247
Copy link
Author

nesl247 commented Oct 5, 2018

Can you explain why you aren’t convinced it’s needed? How do you deal with this situation, which I would imagine impacts almost every user.

@roblourens
Copy link
Member

I'm sure this is useful for some users but our quick open UI is very simple and lightweight and I'd like to keep it that way if at all possible

@skprabhanjan
Copy link
Contributor

But thanks for your enthusiasm :)

Firstly sorry for asking this here!
@roblourens it will be of great help to me if you can assign or let me know on any issue that I can work on and contribute.
Thanks :)

@cdmihai
Copy link

cdmihai commented Jun 12, 2019

I run into this limitation a lot. My build produces a lot of stuff, and I often want to browse the build artifacts:

  • test results. I can do a recursive search string for failed tests, and that UI lets me ignore .gitignore. But sometimes I also want to go to specific test result files via go to file, and can't
  • my build also produces test data, which I want to browse from time to time. I know exactly what the file name is (though not the 100 character path), but I have to use the command line because I can't quickly jump to it via vscode

@roblourens
Copy link
Member

Duplicate of #15604

@roblourens roblourens marked this as a duplicate of #15604 Oct 9, 2019
@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

5 participants