Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search - path to file in 'include' box should be searched #48958

Closed
roblourens opened this issue Apr 30, 2018 · 5 comments
Closed

Search - path to file in 'include' box should be searched #48958

roblourens opened this issue Apr 30, 2018 · 5 comments
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues
Milestone
Backlog

Comments

@roblourens
Copy link
Member

  • Add absolute path to file in the search viewlet's 'include' box
  • No results

We assume it's a folder and don't read the results correctly, but this should work.
@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Apr 30, 2018
@roblourens roblourens self-assigned this Apr 30, 2018
@roblourens roblourens added this to the May 2018 milestone Apr 30, 2018
@roblourens roblourens modified the milestones: May 2018, June 2018 May 30, 2018
@roblourens roblourens mentioned this issue Jun 8, 2018
Closed
@roblourens roblourens modified the milestones: June 2018, July 2018 Jun 28, 2018
This was referenced Jul 11, 2018
Closed
Closed
@roblourens roblourens modified the milestones: September 2018, On Deck Sep 22, 2018
@RMacfarlane RMacfarlane mentioned this issue Jan 12, 2019
Closed
@roblourens roblourens mentioned this issue Mar 2, 2019
Closed
@edespong edespong mentioned this issue Mar 21, 2019
Open
@roblourens
Copy link
Member Author

Not easy - needs search extension API changes.

@roblourens roblourens changed the title Search - absolute path to file in 'include' box should be searched Search - path to file in 'include' box should be searched Oct 9, 2019
@roblourens roblourens mentioned this issue Oct 9, 2019
Closed
@nawfalhasan
Copy link

This would have been so useful, especially with ability to specify multiple files.. :(

@evs-xsarus
Copy link

Not exactly the same, but might give more testcases: #109900

@ArturoDent
Copy link

I solved this in my extension Find and Transform by always using the relative path and for settings.json and keybindings.json trimming the first part of the returned path C:\\ (since there is no relative path to a workspace other than the full path)

@ArturoDent ArturoDent mentioned this issue Dec 13, 2022
Closed
@roblourens roblourens removed this from the On Deck milestone Dec 13, 2022
@roblourens roblourens added this to the Backlog milestone Dec 13, 2022
@roblourens
Copy link
Member Author

#20530

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@roblourens @nawfalhasan @ArturoDent @evs-xsarus