Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ES2018 as target to the used tsconfig-schema.json #43342

Closed
omniproc opened this issue Feb 9, 2018 · 1 comment
Closed

Add ES2018 as target to the used tsconfig-schema.json #43342

omniproc opened this issue Feb 9, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues json JSON support issues verified Verification succeeded
Milestone

Comments

@omniproc
Copy link

omniproc commented Feb 9, 2018

  • VSCode Version: Code 1.19.2 (490ef76, 2018-01-10T15:55:03.538Z)
  • OS Version: Windows_NT x64 10.0.14393

vscode will download the tsconfig-schema.json used for tsconfig validation, which is awesome.
TS 2.7 just added support for ES2018 targets, see microsoft/TypeScript#20385

the current tsconfig-schema yet doesn't allow to use this. I'm not sure where you're pulling the schema from otherwise I'd added a pull request myself.

P.S.: note that with json-schema draft-07 if/then/else was added for even more flexible dependencies in the schema definition. E.g. "only allow target ES2018 if TS version is >=2.7" would be possible now.

@vscodebot vscodebot bot added the json JSON support issues label Feb 9, 2018
@mjbvz mjbvz self-assigned this Feb 9, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 9, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 9, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 9, 2018

Fixed upstream: SchemaStore/schemastore#404 (comment)

@mjbvz mjbvz closed this as completed Feb 9, 2018
@mjbvz mjbvz added the javascript JavaScript support issues label Feb 9, 2018
@octref octref added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues json JSON support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants