Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder to find, use the regular search no results #35012

Closed
ChaimHong opened this issue Sep 26, 2017 · 4 comments
Closed

Folder to find, use the regular search no results #35012

ChaimHong opened this issue Sep 26, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@ChaimHong
Copy link

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions:
Extension Author (truncated) Version
beautify Hoo 1.1.1
json-tools eri 1.0.2
Go luk 0.6.65
csharp ms- 1.12.1

When using the folder search, find the results. My search is a regular statement, open a single file the same use of this regular statement is no problem.
My regular "^\s*$\n", the purpose is to remove the blank line

@vscodebot vscodebot bot added the search Search widget and operation issues label Sep 26, 2017
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2017
@roblourens
Copy link
Member

^\s*$\n won't work because multiline search isn't supported. But I just fixed it so ^\s*$ will work, without the newline.

@roblourens roblourens added this to the September 2017 milestone Sep 26, 2017
@sandy081 sandy081 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Sep 28, 2017
@sandy081
Copy link
Member

@roblourens Above regex is showing invalid results. Also the results view looks broken

image

@sandy081 sandy081 reopened this Sep 28, 2017
@roblourens
Copy link
Member

roblourens commented Sep 28, 2017

rg is returning some extra incorrect results. The results view is correct though since it's supposed to be matching empty lines.

@roblourens
Copy link
Member

Fixed upstream, need 0.7.0+ BurntSushi/ripgrep#599

@roblourens roblourens modified the milestones: November 2017, December 2017 Dec 2, 2017
@aeschli aeschli added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants