Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.tokenColorCustomizations.textMateRules.settings.background not applied #32759

Closed
bilogic opened this issue Aug 18, 2017 · 1 comment
Closed

Comments

@bilogic
Copy link

bilogic commented Aug 18, 2017

  • VSCode Version: 1.15.1 x86
  • OS Version: Windows 7 x64

Steps to Reproduce:

  1. Add to settings
 "editor.tokenColorCustomizations":
    {
        "textMateRules":[        
            {
                
                "name": "Invalid",                
                "scope": "invalid",
                "settings": {
                    "background": "#FF0000",
                    "foreground": "#FFFFFF"
                }
            }
        ],
        "strings": "#3ad900"        
    },    
  1. foreground color #FFFFFF is applied, but background color #FF0000 is not, it remains as it is (#800F00)
  2. Using Generate color theme from current settings shows 2 sets of "Invalid"
		{
			"name": "Invalid",
			"scope": "invalid",
			"settings": {
				"background": "#800F00",
				"foreground": "#F8F8F8"
			}
		},
...
		{
			"name": "Invalid",
			"scope": "invalid",
			"settings": {
				"background": "#FF0000",
				"foreground": "#FFFFFF"
			}
		}
  1. I'm expecting either set 1 or set 2 to be used, however, background is from set 1, foreground is from set 2.
  2. Looks like a bug to me, or is it by design?

Reproduces without extensions: Yes

@aeschli
Copy link
Contributor

aeschli commented Aug 18, 2017

It's a known limitation.

duplicate of #3429

@aeschli aeschli closed this as completed Aug 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants