Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoFindInSelection option to find widget #21976

Closed
rodrigoestevao opened this issue Mar 4, 2017 · 5 comments
Closed

Add autoFindInSelection option to find widget #21976

rodrigoestevao opened this issue Mar 4, 2017 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality

Comments

@rodrigoestevao
Copy link

  • VSCode Version: 1.10.1
  • OS Version: Windows 7 64bits, OSX 10.6

Steps to Reproduce:

  1. Select some block of text;
  2. Ctrl + H to replace some text
@sandy081 sandy081 assigned alexdima and unassigned sandy081 Mar 6, 2017
@alexdima alexdima added editor-find Editor find operations *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Mar 8, 2017
@alexdima
Copy link
Member

alexdima commented Mar 8, 2017

To limit the searching (or the replacing) to a selection you must press the "Find in selection" button in the find widget:

image

@alexdima alexdima closed this as completed Mar 8, 2017
@rodrigoestevao
Copy link
Author

rodrigoestevao commented Mar 8, 2017 via email

@alexdima alexdima changed the title The replace windows does not detect when we have a selected block of text and start replacing from the beginning of the file Add autoFindInSelection option to find widget Mar 8, 2017
@alexdima alexdima reopened this Mar 8, 2017
@alexdima alexdima added feature-request Request for new features or functionality and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Mar 8, 2017
@alexdima
Copy link
Member

alexdima commented Mar 8, 2017

Ok, I understand. You would like the "Find in Selection" toggle to automatically be set to on when launching the find widget from an editor which has a selection. There are plenty of other users that do not want such a behaviour, I therefore suggest we rename the issue to something more clear such as: "Add autoFindInSelection option"

@rodrigoestevao
Copy link
Author

Yes Alex, this is my suggestion. Thank you a lot for your attention.

@alexdima
Copy link
Member

alexdima commented Mar 9, 2017

I ran today across a duplicate, so I suggest we track this request in #15148

@alexdima alexdima closed this as completed Mar 9, 2017
@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants