Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal links: Understand line and column information after a file path #21182

Closed
kieferrm opened this issue Feb 22, 2017 · 3 comments
Closed

Terminal links: Understand line and column information after a file path #21182

kieferrm opened this issue Feb 22, 2017 · 3 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Milestone
Backlog

Comments

@kieferrm
Copy link
Member

While testing #21021.

tsc generates error messages of the following form:

[10:13:10] Error: /Users/me/Development/projects/vscode/extensions/html/server/src/modes/htmlMode.ts(36,31): Property 'findDocumentSymbols' does not exist on type 'LanguageService'.
[10:13:10] Error: /Users/me/Development/projects/vscode/extensions/markdown/src/extension.ts(50,36): Property 'com_mands' does not exist on type 'typeof 'vscode''.

The files are correctly linkified. We should have a link detection extension that also includes the line and column information so that we can directly jump to the error by clicking the link.
@kieferrm kieferrm added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Feb 22, 2017
@Tyriar Tyriar self-assigned this Feb 22, 2017
@Tyriar Tyriar added this to the Backlog milestone Feb 22, 2017
@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2017

Related: #20676 #15179

@Tyriar Tyriar mentioned this issue Mar 9, 2017
Closed
@jonaskello
Copy link

I think this is solved in the April 2017 (version 1.12) release.

However I would like it to match also when the line and column are within brackets like [10, 22] in order to work with tslint and other tools that use this style. Related tslint issue here.

@Tyriar Tyriar mentioned this issue May 9, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented May 9, 2017

Thanks for pointing that out @jonaskello, closing as duplicate. Moved the bracket issue to #26330

@Tyriar Tyriar closed this as completed May 9, 2017
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels May 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jonaskello @Tyriar @kieferrm