Exclude git-rebase-todo in recently opened

[wenfangdu]

The recently opened picker does currently not support files.exclude or search.exclude setting, you would have to open a new feature request.

Originally posted by @bpasero in #203872 (comment)

Currently, search.exclude and files.exclude don't work for workbench.action.openRecent:

{
  "files.exclude": {
    "**/.git/**": true
  },
  "search.exclude": {
    "**/.git/**": true
  }
}

Please add support.

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[wenfangdu]

@bpasero I think this feature request is pretty basic, from my past experience, issues moved to the backlog candidate most likely get closed, could you please consider moving it to the backlog?

[franciscacarneiro]

Hello, @andremmsilva and I would like to start working in this. If moved to the backlog, could this issue be assigned to us? Thank you!

[bpasero]

I wonder if the example above falls into the category of this filter which we maintain already:

vscode/src/vs/platform/workspaces/electron-main/workspacesHistoryMainService.ts

Lines 301 to 304 in f5d6ea1

	private static readonly COMMON_FILES_FILTER = [
	'COMMIT_EDITMSG',
	'MERGE_MSG'
	];

The idea here being to not automatically add git related files to the history. Is your case any special in terms of git operations?

[wenfangdu]

@bpasero I use git rebase a lot, git-rebase-todo should also be filtered out from workbench.action.openRecent, since they are only temporary files:

[bpasero]

Yeah that sounds reasonable to me, feel free to add it as PR.

[TylerLeonhardt]

duplicate of #157395 ?

[TylerLeonhardt]

related: #15604

[bpasero]

@TylerLeonhardt this FR is for the "File" > "Open Recent" > "More..." picker. I actually think #157395 can be closed as fixed for March already, I commented.

[wenfangdu]

Yeah that sounds reasonable to me, feel free to add it as PR.

@bpasero See #211614

[vscodenpa]

This bug has been fixed in the latest release of VS Code Insiders!

@wenfangdu, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 03dd3c3 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[wenfangdu]

@bpasero Is this released in 1.90.2? If it is, I think the PR #211614 didn't solve this issue.

[bpasero]

Yes, this was part of the 1.90.x release.

[wenfangdu]

@bpasero Thanks, perhaps reopen this issue? I just tried, the issue still exists.

[bpasero]

It works for me:

• touch ./git-rebase-todo
• code-insiders ./git-rebase-todo
• File > Open Recent : the file does not appear
• File > Open Recent > More : the file does not appear

[wenfangdu]

@bpasero Can you please try touch ./.git/git-rebase-todo, then the rest?

[bpasero]

Same